Removed midi client disposal on Manager deinit

orchetect · Feb 28, 2022 · 5a0b5f2 · 5a0b5f2
1 parent 874de47
commit 5a0b5f2
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/Sources/MIDIKit/IO/Manager/Manager.swift b/Sources/MIDIKit/IO/Manager/Manager.swift
@@ -131,13 +131,9 @@ extension MIDI.IO {
 
         deinit {
             eventQueue.sync {
-                let result = MIDIClientDispose(coreMIDIClientRef)
-
-                if result != noErr {
-                    // not important to log this, we can omit it for now
-                    //let osStatusMessage = MIDIOSStatus(rawValue: result).description
-                    //logger.debug("Error disposing of MIDI client: \(osStatusMessage)")
-                }
+                // Apple docs:
+                // "Don’t explicitly dispose of your client; the system automatically disposes all clients when an app terminates. However, if you call this method to dispose the last or only client owned by an app, the MIDI server may exit if there are no other clients remaining in the system"
+                //_ = MIDIClientDispose(coreMIDIClientRef)
 
                 NotificationCenter.default.removeObserver(self)
             }