Enforce non null @section values to prevent dangling output buffers #2764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2763
Calling
@sectionwith a null value trigger a bug that does not close an output buffer, causing PHPUnit to mark tests that use this view without name or description defined to be marked as risky.Proposed Changes
Changes introduced by d9700e9 removed the
efunction call that fallback to empty string when called with null.Using a
stringcast forcenullvalues to be empty string.More references: https://laracasts.com/discuss/channels/testing/test-code-or-tested-code-did-not-only-close-its-own-output-buffers-actingas