-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(log): switch to tracing
for logging
#163
Conversation
Looks great! We only need one change, see #161 (comment) |
|
Codecov ReportAttention: ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
LGTM, just one thing, can you configure tracing subscriber so that the default log level will be |
@orhun Good point. Done in b18610c thanks to https://docs.rs/tracing-subscriber/latest/tracing_subscriber/filter/struct.EnvFilter.html#method.from_default_env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super awesome!
tracing
for logging
resolves #161
Description
Only changing
env_logger
intotracing-subscriber
. It should support the same configuration withRUST_LOG
(and more, if we convert fromlog
totracing
later).Motivation and Context
See #161.
How Has This Been Tested?
Logging are usually not tested. If any test would be needed, could you give some pointers?
Changelog Entry
-->
Types of Changes
Checklist: