Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 10068 #10089

Merged
merged 19 commits into from
Feb 8, 2024
Merged

Issue 10068 #10089

merged 19 commits into from
Feb 8, 2024

Conversation

andrii0lomakin
Copy link
Member

Fix of issue #10068 .

  1. Exception on the Linux platform was fixed during storage initialization.
  2. The build number is stored correctly during the build of the project.

@andrii0lomakin
Copy link
Member Author

This branch was based on 4.0.x, so I had to rebase a bunch of commits.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to delete completely this class on 4.0.x so no need to do evolution on this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it: -) I planned to do the same.

Release 17 tag set on maven compiler plugin.
@andrii0lomakin
Copy link
Member Author

andrii0lomakin commented Feb 6, 2024

I have also added maven.release property to avoid usage of API introduced in later JDKs.

@tglman
Copy link
Member

tglman commented Feb 6, 2024

Hi,

A quick review on this:

this commit 7ee1aa6 should be already somehow on develop this: f92ddb4 we do support only java17+ so we cannot use jdk18+ dependencies develop should be already in a good state for cert generation

this: 0ba2b14 is quite welcome, but it has a bit of formatting in it that maybe should not be in this commit

this: 573b160 is good to merge
this: 53a3936 good to merge
this: 404b3fc more than happy to merge it
this: a280f2b good to merge as well

these two:d289fd3, d6d8909 should be redundant as well, it's ok if some of the good commit introduce some specific java 21 changes

Code formatting, so : 18fe41d and 60bcf31 I do not want yet to upgrade the development formatter for another 1/2 weeks, because of some old changes I've pending, so I would prefer keep these out.

@andrii0lomakin
Copy link
Member Author

@tglman jdk8on is about 1.8+ not about 18+

@andrii0lomakin
Copy link
Member Author

@tglman may I ask you to add comments on commit level, so we can discuss observation ?

@andrii0lomakin
Copy link
Member Author

It is hard to discuss observations otherwise

@andrii0lomakin
Copy link
Member Author

@tglman I will roll back code formatting.

@andrii0lomakin
Copy link
Member Author

@tglman, if you have already added changes, can we go with the current code formatter? The old one does not support new language features. Also as I mentioned, jdk18on dependency is not about Java 18, it is about Java 1.8+

To check run - `mvn artifact:check-buildplan`

Code formatting.
To check run - `mvn artifact:check-buildplan`

Code formatting.
core/pom.xml Outdated Show resolved Hide resolved
@andrii0lomakin andrii0lomakin merged commit c7591da into develop Feb 8, 2024
6 checks passed
@andrii0lomakin andrii0lomakin deleted the issue-10068 branch February 8, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants