-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 10068 #10089
Issue 10068 #10089
Conversation
Fix of dependencies with security vulnerabilities.
2. Fix of compilation errors. 3. Code reformatting.
…ervations were fixed.
This branch was based on 4.0.x, so I had to rebase a bunch of commits. |
3979936
to
573b160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning to delete completely this class on 4.0.x so no need to do evolution on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got it: -) I planned to do the same.
Release 17 tag set on maven compiler plugin.
I have also added |
Hi, A quick review on this: this commit 7ee1aa6 should be already somehow on develop this: f92ddb4 we do support only java17+ so we cannot use jdk18+ dependencies develop should be already in a good state for cert generation this: 0ba2b14 is quite welcome, but it has a bit of formatting in it that maybe should not be in this commit this: 573b160 is good to merge these two:d289fd3, d6d8909 should be redundant as well, it's ok if some of the good commit introduce some specific java 21 changes Code formatting, so : 18fe41d and 60bcf31 I do not want yet to upgrade the development formatter for another 1/2 weeks, because of some old changes I've pending, so I would prefer keep these out. |
@tglman jdk8on is about 1.8+ not about 18+ |
@tglman may I ask you to add comments on commit level, so we can discuss observation ? |
It is hard to discuss observations otherwise |
@tglman I will roll back code formatting. |
@tglman, if you have already added changes, can we go with the current code formatter? The old one does not support new language features. Also as I mentioned, jdk18on dependency is not about Java 18, it is about Java 1.8+ |
To check run - `mvn artifact:check-buildplan` Code formatting.
To check run - `mvn artifact:check-buildplan` Code formatting.
Fix of issue #10068 .