Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cargo-deny-action and fix clippy suggestions #397

Merged
merged 8 commits into from
Aug 25, 2024
Merged

Conversation

brycx
Copy link
Member

@brycx brycx commented Aug 16, 2024

A few maintenance changes:

  • Update cargo-deny-action to 2.0.1
  • Include 2024 in SHA3 copyright header
  • Satisfy new clippy lints
  • Remove one test from SHA2 that checked for panic on overflow with 64-bit int, but this is useless because
    1. We don't run CI in 128-bit targets
    2. Rust has no longer any 128-bit targets listed in their supported target (I'm pretty sure there were some at one point, haven't found it though)
    3. The pointer target width doesn't even have 128 so we can't check it (thanks for catching this clippy)

@vlmutolo do you happen to have time to check this through? should mostly be trivial changes but there's a few of them

@brycx brycx requested a review from vlmutolo August 16, 2024 07:52
@brycx brycx removed the request for review from vlmutolo August 25, 2024 07:50
@brycx brycx merged commit a6c1649 into master Aug 25, 2024
23 checks passed
@brycx brycx deleted the clippy_deny_action branch August 25, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant