PHPStan: new options

orisai · Jun 21, 2024 · 8ce3d1b · 8ce3d1b
1 parent fbea7b8
commit 8ce3d1b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 13 deletions.
diff --git a/src/Enum/ParameterIn.php b/src/Enum/ParameterIn.php
@@ -33,15 +33,25 @@ final class ParameterIn
 		'query' => ['form', 'spaceDelimited', 'pipeDelimited', 'deepObject'],
 	];
 
-	/** @readonly */
+	/**
+	 * @var value-of<self::ValuesAndNames>
+	 * @readonly
+	 */
 	public string $name;
 
-	/** @readonly */
+	/**
+	 * @var key-of<self::ValuesAndNames>
+	 * @readonly
+	 */
 	public string $value;
 
 	/** @var array<string, self> */
 	private static array $instances = [];
 
+	/**
+	 * @param value-of<self::ValuesAndNames> $name
+	 * @param key-of<self::ValuesAndNames> $value
+	 */
 	private function __construct(string $name, string $value)
 	{
 		$this->name = $name;

diff --git a/tools/phpstan.baseline.neon b/tools/phpstan.baseline.neon
@@ -1,5 +1,10 @@
 parameters:
 	ignoreErrors:
+		-
+			message: "#^Parameter \\#2 \\$value of class Orisai\\\\OpenAPI\\\\Enum\\\\ParameterIn constructor expects 'cookie'\\|'header'\\|'path'\\|'query', string given\\.$#"
+			count: 1
+			path: ../src/Enum/ParameterIn.php
+
 		-
 			message: "#^Parameter \\#1 \\$name of method Orisai\\\\OpenAPI\\\\Spec\\\\Encoding\\:\\:addContentType\\(\\) expects non\\-empty\\-string, string given\\.$#"
 			count: 1
@@ -50,16 +55,6 @@ parameters:
 			count: 1
 			path: ../tests/Unit/Spec/ResponsesTest.php
 
-		-
-			message: "#^Offset 0 might not exist on list\\<string\\|null\\>\\|null\\.$#"
-			count: 1
-			path: ../tests/Unit/Utils/HeadersTest.php
-
-		-
-			message: "#^Offset 1 might not exist on list\\<string\\|null\\>\\|null\\.$#"
-			count: 1
-			path: ../tests/Unit/Utils/MediaTypesTest.php
-
 		-
 			message: "#^Parameter \\#1 \\$mediaType of static method Orisai\\\\OpenAPI\\\\Utils\\\\MediaTypes\\:\\:format\\(\\) expects non\\-empty\\-string, string given\\.$#"
 			count: 1

diff --git a/tools/phpstan.neon b/tools/phpstan.neon
@@ -3,7 +3,7 @@ includes:
 	- phpstan.baseline.neon
 
 parameters:
-	phpVersion: 70400
+	phpVersion: 80300
 	level: 8
 	tmpDir: ../var/tools/PHPStan
 	resultCachePath: %currentWorkingDirectory%/var/tools/PHPStan/resultCache.php
@@ -12,6 +12,8 @@ parameters:
 	checkMissingCallableSignature: true
 	checkInternalClassCaseSensitivity: true
 	checkTooWideReturnTypesInProtectedAndPublicMethods: true
+	reportAnyTypeWideningInVarTag: true
+	reportPossiblyNonexistentConstantArrayOffset: true
 
 	exceptions:
 		check: