Extend Derived Variable Expressions: Multiplication, Division, Pow, Sqrt #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anagainaru
reviewed
Aug 1, 2024
anagainaru
reviewed
Aug 2, 2024
…sion, exponent, and square root
anagainaru
force-pushed
the
extendExprs
branch
2 times, most recently
from
33a679e
to
4a440b2
Compare
anagainaru
force-pushed
the
extendExprs
branch
2 times, most recently
from
1a59b9a
to
00b92c6
Compare
anagainaru
force-pushed
the
extendExprs
branch
from
65bea72
to
59ad845
Compare
anagainaru
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, division needs to be called as "divide( ... )" since '/' character can be found in variable names, so "sim/Ux" could be a variable name or division operation.
All simple functions were merged into one test
Edit from Ana
Two things are left for @lizdulac
Powderived variable returns pow(var, 2) and should work with any index value