Extend Derived Variable Expressions: Trig functions #4282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lizdulac
changed the title
anagainaru
requested changes
Aug 13, 2024
Comment on lines
42
to
58
| template <class T> | ||
| T *ApplyOneToOneOnce(T *inputData, size_t dataSize, std::function<T(T)> compFct) | ||
| { | ||
| T *outValues = (T *)malloc(dataSize * sizeof(T)); | ||
| if (outValues == nullptr) | ||
| { | ||
| helper::Throw<std::invalid_argument>("Derived", "Function", "ApplyOneToOneOnce", | ||
| "Error allocating memory for the derived variable"); | ||
| } | ||
| for (size_t i = 0; i < dataSize; i++) | ||
| { | ||
| T data = *(reinterpret_cast<T *>(inputData + i)); | ||
| outValues[i] = compFct(data); | ||
| } | ||
| return outValues; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function is basically a std::transform. Check how sqrt is implemented now and update the trig functions using the same method.
anagainaru
requested changes
Aug 19, 2024
anagainaru
reviewed
Aug 19, 2024
anagainaru
previously approved these changes
Aug 19, 2024
anagainaru
reviewed
Aug 20, 2024
anagainaru
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend Derived Variable Expressions to include sin, cos, tan, asin, acos, atan