Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVCache use MinBlocksInfo to get start/count in query #4294

Merged
merged 5 commits into from
Aug 13, 2024

Conversation

Change72
Copy link
Contributor

@Change72 Change72 commented Aug 7, 2024

Use MinBlocksInfo to get start/count in the query (touched blocks). The start/count will be saved in KVCache and will be used in partial overlap cases in the future.

In the current code, MinBlocksInfoMap will temporarily hold the minBlocksInfo in memory in order to avoid the repeat MinBlocksInfo(*VB, Req.RelStep); for the same variable.

However, MinBlocksInfoMap only works for mode::deferred, and not for mode::Sync.

pnorbert
pnorbert previously approved these changes Aug 12, 2024
Copy link
Contributor

@pnorbert pnorbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move MinBlocksInfoMap to be a private class member, and free it up in EndStep(). Then it should work with Sync mode as well.

pnorbert
pnorbert previously approved these changes Aug 12, 2024
@pnorbert pnorbert merged commit bc0d681 into ornladios:master Aug 13, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants