Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove manifest.xml files #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rayman
Copy link

@Rayman Rayman commented Jul 10, 2020

rosbuild support has been removed with ROS indigo. So these files are
not used anymore. More importantly, rosdep gets confused and loads both
manifest.xml and package.xml files, and will install the wrong
dependencies.

rosbuild support has been removed with ROS indigo. So these files are
not used anymore. More importantly, rosdep gets confused and loads both
manifest.xml and package.xml files, and will install the wrong
dependencies.
@meyerj
Copy link
Member

meyerj commented Jul 10, 2020

Thanks! In general, the manifest.xml files are also used by another build tool used by the Rock community, Autoproj. The incompatibility with rosdep and diverged specification is a known and long lasting issue:

I am not aware of someone using rtt_soem with Autoproj and also did not find any hints with Google. So I am fine with removing old files related to rosbuild. If needed, we can still restore and update them.

Could you please remove all manifest.xml files, but also Makefile, mainpage.dox and the top-level stack.xml and CMakeLists.txt? They have all been created by legacy ROS tools. Some CMakeLists.txt still have conditional branches for rosbuild, which should be cleaned, too.

soem_core has been ignored and replaced by https://github.com/smits/soem a long time ago. So it is fine to leave it untouched and we can remove the folder in a follow-up PR. Or just also remove it here.

@Rayman
Copy link
Author

Rayman commented Jul 10, 2020

Yes, I'll do that. Thanks for your response, I was not aware of that discussion

@Rayman Rayman changed the title Remove manifest.xml files [WIP] Remove manifest.xml files Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants