Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proxy flag for additional cors headers #377

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Conversation

afreakk
Copy link
Contributor

@afreakk afreakk commented Sep 12, 2024

When using non standard headers in proxy requests, it results in error like

Preflight aborted: headers 'traceparent' not allowed

With this change you can specify additional headers to allow.

Related Issue or Design Document

#261

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Tests should pass now with the upstream changes.
I assume that you tested the feature already locally? As it is not critical, but rather "nice-to-have", I'm fine not having any unit tests for this.

@zepatrik
Copy link
Member

Ah the other tests are failing because the secret is not available on your branch.

@zepatrik zepatrik requested a review from alnr September 25, 2024 09:18
@zepatrik zepatrik merged commit 6f64ad8 into ory:master Sep 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants