Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update b2b sso organization documentation #1555

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas
Copy link
Member Author

Don't merge, it's not live yet.

@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label Oct 2, 2023
Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its live now right @jonas-jonas ?

Btw do you think it makes sense to keep the example how to configure it via API in, or was that more hacky than it should be?

@jonas-jonas
Copy link
Member Author

Ah, yes, it is.

The API example is really hacky, and we shouldn't have that in the documentation, IMO. The CLI will support it soon (ish): ory/cli#318

But since it doesn't support it yet, might be good to keep the API example in there... I guess I'll revert the removal for now.

@vinckr
Copy link
Member

vinckr commented Oct 19, 2023

I guess I'll revert the removal for now.

Your call 😁
IMO if there are concrete plans to add it to the CLI, we can remove it.
I dont see too many users using it in that way tbh.
But if the CLI/API plans are still a longer time out (say Q1'24) then I would leave it in.

@jonas-jonas
Copy link
Member Author

Then let's merge. @hperl said he's working on the CLI PR still, but should be available soon.

@vinckr vinckr enabled auto-merge (squash) October 19, 2023 19:09
@vinckr vinckr merged commit 5d4b2b4 into master Oct 19, 2023
10 checks passed
@vinckr vinckr deleted the jonas-jonas/b2bSSOUIDocs branch October 19, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants