Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: nginx rewrite conflict with RedirectAdminMiddleware #1940

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Laplace-Transformer
Copy link

@Laplace-Transformer Laplace-Transformer commented Nov 7, 2024

Removed removal of nginx rewrite. Conflicted with "RedirectAdminMiddleware" in the kratos code, which adds the prefix "admin/" if not present.

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Removed removal of nginx rewrite. Conflicted with "RedirectAdminMiddleware" in the kratos code, which adds the prefix "admin/" if not present.
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2024

CLA assistant check
All committers have signed the CLA.

@Laplace-Transformer Laplace-Transformer changed the title Nginx rewrite conflict with RedirectAdminMiddleware docs: nginx rewrite conflict with RedirectAdminMiddleware Nov 7, 2024
@aeneasr
Copy link
Member

aeneasr commented Nov 12, 2024

To merge this we would probably need to run through this example step by step, unless there is a clear reason why this was in there for so long and noone ever noticed it / complained about it?

@Laplace-Transformer
Copy link
Author

Hi again.
There was a breaking change back in 2022, that you introduced:
ory/kratos@8acb4cf

I don't think many people use this documentation. I've tried to follow it but I've had few hiccups on the way that I'm currently trying to correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants