Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make it possible to intercept debug logs #75

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjaglin
Copy link

@bjaglin bjaglin commented Nov 11, 2019

Initial naive implementation of #74

@bjaglin
Copy link
Author

bjaglin commented Nov 11, 2019

Not very satisfied so far as:

  • I went for a PrintStream signature which fits well with the "logging" use-case, but it's not consistent with the existing overload to intercept protoc streams.
  • the overload cascades to all methods as everything is public static
  • for any new functionnality, it would be very easy to log to sdtout by mistake even though the calling context asked for a specific stream

Maybe it's worth using a proper logging framework?

@os72
Copy link
Owner

os72 commented Mar 1, 2020

This could fit with a bigger initiative to make the project more modular, yes less "public static". Pluggable logging, thread-safety, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants