Increase the URL connection and read timeouts to 30 seconds #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing situations when running in Docker that the protoc version download intermittently fails and this breaks the CI build of our code. It's not 100% clear from the log whether a timeout is what occurs given that we don't see why the download fails in the logs, but I believe that a 5 seconds timeout can be pretty short if the network is held up by something else. I think it should be a balanced value to increase this timeout to 30 seconds. This will however slow down the fallback to pick up any cached version if the machine became offline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing situations when running in Docker that the protoc version download intermittently fails
and this breaks the CI build of our code.
It's not 100% clear from the log whether a timeout is what occurs given that we don't see why the download
fails in the logs, but I believe that a 5 seconds timeout can be pretty short if the network is held up by something else.
I think it should be a balanced value to increase this timeout to 30 seconds.
This will however slow down the fallback to pick up any cached version if the machine became offline.