Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osbuild-worker: rework the workerClientErrorFrom() error #4254

Merged
merged 1 commit into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. osbuild-worker: rework the workerClientErrorFrom() error

    The workerClientErrorFrom() was returning an `*clienterrors.Error` and
    an `error` (if something with the conversation goes wrong.
    
    But the calling code was expecting that even if an `error` is returned
    the `*clienterrors.Error` is still valid. The caller would then just
    log the error. As returning a valid `value` even when there is an
    `error` is an unexpected pattern this commit changes the code to
    always return a `*clienterrors.Error` and log any issue via the
    logger.
    mvo5 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    96633ff View commit details
    Browse the repository at this point in the history