Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download errors with Ungoliant #105

Merged
merged 5 commits into from
Jul 25, 2023
Merged

Download errors with Ungoliant #105

merged 5 commits into from
Jul 25, 2023

Conversation

pjox
Copy link
Member

@pjox pjox commented Jul 11, 2023

This PR give a first implementation to download all missing files of an initial Ungoliant download of Common Crawl. It also fixes a problem with the formatting of the output error file.

@pjox pjox requested a review from Uinelj July 11, 2023 13:48
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #105 (10f5244) into dev (8b25ab5) will decrease coverage by 2.12%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev     #105      +/-   ##
==========================================
- Coverage   48.50%   46.38%   -2.12%     
==========================================
  Files          22       22              
  Lines        1138     1190      +52     
==========================================
  Hits          552      552              
- Misses        586      638      +52     
Impacted Files Coverage Δ
src/download.rs 0.00% <0.00%> (ø)

@Uinelj Uinelj merged commit 876e4f2 into dev Jul 25, 2023
1 of 3 checks passed
@Uinelj Uinelj deleted the dev-download branch July 25, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants