Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile #116

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add Dockerfile #116

wants to merge 1 commit into from

Conversation

Uinelj
Copy link
Member

@Uinelj Uinelj commented Aug 9, 2023

Adds both lean and full fledged Docker images to ease use of Ungoliant.
The lean one should only contain the binary (Bring your own model..)
The full fledged one contains it all but the kenlms (they are heavy).

TODO: Another image to do the downloading.
If possible make one that builds everything, and two dockerfiles that inherit from that first one and specializes into generation and downloading :)

@Uinelj Uinelj changed the base branch from main to dev August 9, 2023 15:05
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #116 (f0ed95a) into dev (9234d13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #116   +/-   ##
=======================================
  Coverage   46.97%   46.97%           
=======================================
  Files          22       22           
  Lines        1205     1205           
=======================================
  Hits          566      566           
  Misses        639      639           

@Uinelj
Copy link
Member Author

Uinelj commented Aug 23, 2023

We should have

  • A stage image (ungoliant-base or something along these lines)
  • An ungoliant-download image that only does the downloading part
  • An ungoliant-gen image that generates the dataset, with:
    • An ungoliant-gen:light one that requires you to provide blocklist, model and kenlms
    • An ungoliant-gen:full one that has everything we use internally. Probably big (~20GB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant