Merge with master

.github/workflows/CI.yml

@@ -75,7 +75,7 @@ jobs:
         uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.julia-version }}
-      - uses: julia-actions/cache@v1
+      - uses: julia-actions/cache@v2
         if: runner.environment != 'self-hosted'
         with:
           cache-name: julia-cache;workflow=${{ github.workflow }};julia=${{ matrix.julia-version }};arch=${{ runner.arch }}
@@ -143,7 +143,7 @@ jobs:
         uses: julia-actions/setup-julia@v2
         with:
           version: ${{ matrix.julia-version }}
-      - uses: julia-actions/cache@v1
+      - uses: julia-actions/cache@v2
         if: runner.environment != 'self-hosted'
         with:
           cache-name: julia-cache;workflow=${{ github.workflow }};julia=${{ matrix.julia-version }};arch=${{ runner.arch }}

.github/workflows/JuliaFormatterCI.yml

@@ -21,7 +21,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - uses: julia-actions/setup-julia@v2
-    - uses: julia-actions/cache@v1
+    - uses: julia-actions/cache@v2
     - name: 'Check format with JuliaFormatter'
       run: |
         julia etc/test_formatting.jl

.github/workflows/NoExperimental.yml

@@ -38,7 +38,7 @@ jobs:
         uses: julia-actions/setup-julia@v2
         with:
           version: '1.10'
-      - uses: julia-actions/cache@v1
+      - uses: julia-actions/cache@v2
         with:
           cache-name: julia-cache;workflow=${{ github.workflow }};julia=1.10;arch=${{ runner.arch }}
           include-matrix: false
@@ -62,7 +62,7 @@ jobs:
         uses: julia-actions/setup-julia@v2
         with:
           version: '1.10'
-      - uses: julia-actions/cache@v1
+      - uses: julia-actions/cache@v2
         with:
           cache-name: julia-cache;workflow=${{ github.workflow }};julia=1.10;arch=${{ runner.arch }}
           include-matrix: false

Project.toml

@@ -26,7 +26,7 @@ cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade"
 
 [compat]
 AbstractAlgebra = "0.41.3"
-AlgebraicSolving = "0.4.15"
+AlgebraicSolving = "0.5.0"
 Distributed = "1.6"
 GAP = "0.10.2"
 Hecke = "0.32.0"

docs/oscar_references.bib

@@ -104,20 +104,6 @@ @Article{BCL21
   numpages      = {8}
 }
 
-@Article{BCP97,
-  author        = {Bosma, Wieb and Cannon, John and Playoust, Catherine},
-  title         = {The Magma algebra system. I. The user language},
-  mrnumber      = {1484478},
-  journal       = {J. Symbolic Comput.},
-  fjournal      = {Journal of Symbolic Computation},
-  volume        = {24},
-  number        = {3-4},
-  note          = {Computational algebra and number theory (London, 1993)},
-  pages         = {235--265},
-  year          = {1997},
-  doi           = {10.1006/jsco.1996.0125}
-}
-
 @Article{BDEPS04,
   author        = {Berry, Neil and Dubickas, Artūras and Elkies, Noam D. and Poonen, Bjorn and Smyth, Chris},
   title         = {The conjugate dimension of algebraic numbers},
@@ -348,20 +334,6 @@ @Article{BS09
   doi           = {10.1016/j.aim.2009.06.009}
 }
 
-@Article{Bea00,
-  author        = {Beauville, Arnaud},
-  title         = {Symplectic singularities},
-  mrnumber      = {1738060},
-  journal       = {Invent. Math.},
-  fjournal      = {Inventiones Mathematicae},
-  volume        = {139},
-  number        = {3},
-  pages         = {541--549},
-  year          = {2000},
-  doi           = {10.1007/s002229900043},
-  groups        = {Symplectic singularities}
-}
-
 @Book{Ben93,
   author        = {Benson, David J.},
   title         = {Polynomial invariants of finite groups},
@@ -494,6 +466,19 @@ @Article{CMS07
   doi           = {10.4171/dm/220}
 }
 
+@Article{CMT04,
+  author        = {Cohen, Arjeh M. and Murray, Scott H. and Taylor, D. E.},
+  title         = {Computing in groups of Lie type},
+  mrnumber      = {2047097},
+  journal       = {Math. Comp.},
+  fjournal      = {Mathematics of Computation},
+  volume        = {73},
+  number        = {247},
+  pages         = {1477--1498},
+  year          = {2004},
+  doi           = {10.1090/S0025-5718-03-01582-5}
+}
+
 @Book{CS99,
   author        = {Conway, J. H. and Sloane, N. J. A.},
   title         = {Sphere packings, lattices and groups},
@@ -564,19 +549,6 @@ @Book{Coh00
   doi           = {10.1007/978-1-4419-8489-0}
 }
 
-@Article{Coh80,
-  author        = {Cohen, Arjeh M.},
-  title         = {Finite quaternionic reflection groups},
-  mrnumber      = {579063},
-  journal       = {J. Algebra},
-  fjournal      = {Journal of Algebra},
-  volume        = {64},
-  number        = {2},
-  pages         = {293--324},
-  year          = {1980},
-  doi           = {10.1016/0021-8693(80)90148-9}
-}
-
 @Book{Coh93,
   author        = {Cohen, Henri},
   title         = {A course in computational algebraic number theory},
@@ -809,17 +781,15 @@ @Article{EFS03
   zbmath        = {1963988}
 }
 
-@Article{EG02,
-  author        = {Etingof, Pavel and Ginzburg, Victor},
-  title         = {Symplectic reflection algebras, Calogero-Moser space, and deformed Harish-Chandra homomorphism},
-  mrnumber      = {1881922},
-  journal       = {Invent. Math.},
-  fjournal      = {Inventiones Mathematicae},
-  volume        = {147},
-  number        = {2},
-  pages         = {243--348},
-  year          = {2002},
-  doi           = {10.1007/s002220100171}
+@Book{EH16,
+  author        = {Eisenbud, David and Harris, Joe},
+  title         = {3264 and all that. {A} second course in algebraic geometry},
+  zbl           = {1341.14001},
+  publisher     = {Cambridge: Cambridge University Press},
+  year          = {2016},
+  doi           = {10.1017/CBO9781139062046},
+  language      = {English},
+  zbmath        = {6562439}
 }
 
 @Article{EHU03,
@@ -1199,6 +1169,20 @@ @Article{HHS11
   year          = {2011}
 }
 
+@Article{HM73,
+  author        = {Horrocks, G. and Mumford, D.},
+  title         = {A rank 2 vector bundle on $\text{P}^4$ with 15,000 symmetries},
+  zbl           = {0255.14017},
+  journal       = {Topology},
+  fjournal      = {Topology},
+  volume        = {12},
+  pages         = {63--81},
+  year          = {1973},
+  doi           = {10.1016/0040-9383(73)90022-0},
+  language      = {English},
+  zbmath        = {3402784}
+}
+
 @Book{HP89,
   author        = {Holt, Derek F. and Plesken, W.},
   title         = {Perfect groups},
@@ -1640,15 +1624,6 @@ @Article{LS13
   reportnumber  = {KCL-MTH-12-14}
 }
 
-@Book{LT09,
-  author        = {Lehrer, Gustav I. and Taylor, Donald E.},
-  title         = {Unitary reflection groups},
-  series        = {Australian Mathematical Society Lecture Series},
-  volume        = {20},
-  publisher     = {Cambridge University Press, Cambridge},
-  year          = {2009}
-}
-
 @PhDThesis{Lev05,
   author        = {Viktor Levandovskyy},
   title         = {Non-commutative Computer Algebra for polynomial algebras: Gröbner bases, applications and
@@ -1682,19 +1657,6 @@ @Book{Loo84
   year          = {1984}
 }
 
-@Article{MM10,
-  author        = {Marin, I. and Michel, J.},
-  title         = {Automorphisms of complex reflection groups},
-  mrnumber      = {2746138},
-  journal       = {Represent. Theory},
-  fjournal      = {Representation Theory. An Electronic Journal of the American Mathematical Society},
-  volume        = {14},
-  pages         = {747--788},
-  year          = {2010},
-  doi           = {10.1090/S1088-4165-2010-00380-5},
-  groups        = {Reflection groups}
-}
-
 @Article{MR20,
   author        = {Markwig, Thomas and Ren, Yue},
   title         = {Computing tropical varieties over fields with valuation},
@@ -1756,29 +1718,6 @@ @Book{Mar18
   doi           = {10.1007/978-3-319-90233-3}
 }
 
-@Article{Mer12,
-  author        = {Merca, M},
-  title         = {Fast algorithm for generating ascending compositions},
-  journal       = {J. Math. Model. Algorithms},
-  volume        = {11},
-  number        = {1},
-  pages         = {89--104},
-  year          = {2012},
-  doi           = {10.1007/s10852-011-9168-y}
-}
-
-@Article{Mic15,
-  author        = {Michel, Jean},
-  title         = {The development version of the \texttt{CHEVIE} package of \texttt{GAP}3},
-  mrnumber      = {3343221},
-  journal       = {J. Algebra},
-  fjournal      = {Journal of Algebra},
-  volume        = {435},
-  pages         = {308--336},
-  year          = {2015},
-  doi           = {10.1016/j.jalgebra.2015.03.031}
-}
-
 @Article{Nik79,
   author        = {Nikulin, V. V.},
   title         = {Integer symmetric bilinear forms and some of their geometric applications},
@@ -2013,18 +1952,6 @@ @Article{SS12
   doi           = {10.1016/j.jcta.2011.12.005}
 }
 
-@Article{ST54,
-  author        = {Shephard, G. C. and Todd, J. A.},
-  title         = {Finite unitary reflection groups},
-  mrnumber      = {59914},
-  journal       = {Canad. J. Math.},
-  fjournal      = {Canadian Journal of Mathematics. Journal Canadien de Mathématiques},
-  volume        = {6},
-  pages         = {274--304},
-  year          = {1954},
-  doi           = {10.4153/cjm-1954-028-3}
-}
-
 @Article{SV-D-V87,
   author        = {Sommese, Andrew John and Van de Ven, A.},
   title         = {On the adjunction mapping},

docs/src/CommutativeAlgebra/GroebnerBases/groebner_bases_integers.md

@@ -60,12 +60,12 @@ Ideal generated by
 
 julia> G = groebner_basis(I, ordering = lex(R))
 Gröbner basis with elements
-1 -> 28*y^3 - 35*y
-2 -> 4*x*y^2 - 5*x
-3 -> 15*x^2 + 28*y^2
-4 -> 3*x^2*y + 7*y
-5 -> x^2*y^2 - 5*x^2 - 7*y^2
+  1 -> 28*y^3 - 35*y
+  2 -> 4*x*y^2 - 5*x
+  3 -> 15*x^2 + 28*y^2
+  4 -> 3*x^2*y + 7*y
+  5 -> x^2*y^2 - 5*x^2 - 7*y^2
 with respect to the ordering
-lex([x, y])
+  lex([x, y])
 ```
 

docs/src/Groups/pcgroup.md

@@ -8,7 +8,7 @@ DocTestSetup = Oscar.doctestsetup()
 ```@docs
 PcGroup
 PcGroupElem
-map_word(g::PcGroupElem, genimgs::Vector; genimgs_inv::Vector = Vector(undef, length(genimgs)), init = nothing)
+map_word(g::Union{PcGroupElem, SubPcGroupElem}, genimgs::Vector; genimgs_inv::Vector = Vector(undef, length(genimgs)), init = nothing)
 ```
 
 Julia has the following functions that allow to generate polycyclic groups:

experimental/FTheoryTools/src/AbstractFTheoryModels/attributes.jl

@@ -1031,12 +1031,15 @@ Assuming that the first row of the given grading is the grading under Kbar
 Hypersurface model over a not fully specified base
 
 julia> gauge_algebra(t)
-5-element Vector{LinearLieAlgebra{QQBarFieldElem}}:
- Special linear Lie algebra of degree 2 over QQBar
- Special linear Lie algebra of degree 2 over QQBar
- Special linear Lie algebra of degree 2 over QQBar
- Special linear Lie algebra of degree 2 over QQBar
- Linear Lie algebra with 1x1 matrices over QQBar
+Direct sum Lie algebra
+  of dimension 13
+with summands
+  sl_2
+  sl_2
+  sl_2
+  sl_2
+  linear Lie algebra
+over field of algebraic numbers
 ```
 """
 function gauge_algebra(m::AbstractFTheoryModel)

experimental/FTheoryTools/src/AbstractFTheoryModels/methods.jl

@@ -634,27 +634,25 @@ function set_gauge_algebra(m::AbstractFTheoryModel, algebras::Vector{String})
   C = algebraic_closure(QQ)
   function _construct(g::String)
     if g == "0"
-      return nothing
-    end
-    if g == "u(1)"
+      return abelian_lie_algebra(C, 0)
+    elseif g == "u(1)"
       return lie_algebra(C,1,[C(1im)*identity_matrix(C,1)],["i"])
     elseif g[1:2] == "su"
       return special_linear_lie_algebra(C, parse(Int, g[4:end-1]))
     elseif g[1:2] == "so"
       return special_orthogonal_lie_algebra(C, parse(Int, g[4:end-1]))
     elseif g[1:2] == "sp"
       return symplectic_lie_algebra(C, parse(Int, g[4:end-1]))
-      #For the algebras that are constructed from their Dynkin diagramms we cannot use QQBarField as the current implementation looks for a GAP iso and finds none.
-    elseif g[1] == "e"
-      return lie_algebra(QQ, Symbol('E'), parse(Int, g[3:end-1]))
-    elseif g[1] == "g"
-      return lie_algebra(QQ, Symbol('G'), parse(Int, g[3:end-1]))
-    #elseif g[1] == "f" This is not implemented yet  
-      #return lie_algebra(C,Symbol('G'),parse(Int, g[3:end-1]));
+    elseif g[1:1] == "e"
+      return lie_algebra(C, :E, parse(Int, g[3:end-1]))
+    elseif g[1:1] == "f"
+      return lie_algebra(C, :F, parse(Int, g[3:end-1]))
+    elseif g[1:1] == "g"
+      return lie_algebra(C, :G, parse(Int, g[3:end-1]))
     end
+    error("Unknown algebra description")
   end
-  gauge_algebras = [_construct(g) for g in algebras]
-  set_attribute!(m, :gauge_algebra => gauge_algebras)
+  set_attribute!(m, :gauge_algebra => direct_sum(C, LieAlgebra{elem_type(C)}[_construct(g) for g in algebras]))
 end
 
 function set_global_gauge_quotients(m::AbstractFTheoryModel, quotients::Vector{Vector{String}})

experimental/FTheoryTools/src/LiteratureModels/Models/model1903.00009.json

@@ -1,5 +1,5 @@
 {
-    "model_index": "13",
+    "model_index": "45",
     "arxiv_data": {
         "id": "1903.00009",
         "doi": "10.48550/arXiv.1903.00009",