Skip to content

Commit

Permalink
Fixed some bugs that were missed before
Browse files Browse the repository at this point in the history
Some small bug fixes that were missed in some recents pull requests relating to model indexes and other stuff.
  • Loading branch information
emikelsons committed Oct 7, 2024
1 parent 1217ab3 commit 8dda8bb
Show file tree
Hide file tree
Showing 6 changed files with 42 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"model_data": {
"base_dim": 3,
"defining_classes": ["w"],
"zero_section_class": "z",
"model_sections": ["w", "a1", "a21", "a32", "a43"],
"a1": "a1",
"a2": "a21*w",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
[1, 2, 3, 4, 6]
],
"zero_section_class": "z",
"zero_section": ["1", "1", "0"]
"zero_section": ["1", "1", "0"],
"resolutions": [
[
[
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ function literature_model(model_dict::Dict{String, Any}; model_parameters::Dict{
if model_dict["arxiv_data"]["id"] == "1903.00009"

# Read in the QSM-model form the database
model_dict["literature_identifier"] = "1903.00009"
model_dict["literature_identifier"] = "1903_00009"
k = model_parameters["k"]
qsmd_path = artifact"QSMDB"
qsm_model = load(joinpath(qsmd_path, "$k.mrdi"))
Expand Down Expand Up @@ -634,7 +634,7 @@ function _set_all_attributes(model::AbstractFTheoryModel, model_dict::Dict{Strin
set_zero_section(model, string.(model_dict["model_data"]["zero_section"]))
end

if haskey(model_dict["model_data"], "zero_section_class")
if haskey(model_dict["model_data"], "zero_section_class") && !(base_space(model) isa FamilyOfSpaces)
set_zero_section_class(model, string.(model_dict["model_data"]["zero_section_class"]))
end

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,6 @@ function _create_literature_model_index()
JSON.print(file, index)
end
open(joinpath(@__DIR__,"model_indices.json"), "w") do file
JSON.print(file, sort(model_indices), 2)
JSON.print(file, model_indices, 2)
end
end
2 changes: 1 addition & 1 deletion experimental/FTheoryTools/src/LiteratureModels/index.json

Large diffs are not rendered by default.

72 changes: 36 additions & 36 deletions experimental/FTheoryTools/src/LiteratureModels/model_indices.json
Original file line number Diff line number Diff line change
@@ -1,48 +1,48 @@
{
"model1109_3454.json": "1",
"model1208_2695-1.json": "2",
"model1208_2695-2.json": "3",
"model1212_2949-1.json": "4",
"model1212_2949-2.json": "5",
"model1212_2949-3.json": "6",
"model1212_2949-4.json": "7",
"model1212_2949-5.json": "8",
"model1212_2949-6.json": "9",
"model1212_2949-7.json": "10",
"model1408_4808-1-WSF.json": "13",
"model1511_03209.json": "46",
"model1408_4808-1.json": "14",
"model1408_4808-10-WSF.json": "31",
"model1408_4808-10.json": "32",
"model1408_4808-11-WSF.json": "33",
"model1408_4808-11.json": "34",
"model1408_4808-1-WSF.json": "13",
"model1212_2949-6.json": "9",
"model1408_4808-14.json": "40",
"model1408_4808-12-WSF.json": "35",
"model1408_4808-12.json": "36",
"model1408_4808-13-WSF.json": "37",
"model1408_4808-13.json": "38",
"model1408_4808-14-WSF.json": "39",
"model1408_4808-14.json": "40",
"model1408_4808-15-WSF.json": "41",
"model1408_4808-15.json": "42",
"model1408_4808-16-WSF.json": "43",
"model1408_4808-16.json": "44",
"model1408_4808-2-WSF.json": "15",
"model1408_4808-2.json": "16",
"model1408_4808-3-WSF.json": "17",
"model1408_4808-3.json": "18",
"model1408_4808-4-WSF.json": "19",
"model1408_4808-4.json": "20",
"model1408_4808-5-WSF.json": "21",
"model1212_2949-2.json": "5",
"model1212_2949-7.json": "10",
"model1408_4808-5.json": "22",
"model1408_4808-6-WSF.json": "23",
"model1408_4808-6.json": "24",
"model1212_2949-1.json": "4",
"model1408_4808-7-WSF.json": "25",
"model1408_4808-7.json": "26",
"model1408_4808-8-WSF.json": "27",
"model1408_4808-8.json": "28",
"model1208_2695-2.json": "3",
"model1408_4808-14-WSF.json": "39",
"model1903_00009.json": "47",
"model1408_4808-4-WSF.json": "19",
"model1408_4808-9-WSF.json": "29",
"model1408_4808-9.json": "30",
"model1408_4808-6-WSF.json": "23",
"model1408_4808-13-WSF.json": "37",
"model1408_4808-11-WSF.json": "33",
"model1408_4808-10-WSF.json": "31",
"model1212_2949-3.json": "6",
"model1507_05954-1.json": "11",
"model1212_2949-4.json": "7",
"model1408_4808-8.json": "28",
"model1507_05954-2.json": "12",
"model1511_03209.json": "46",
"model1903_00009.json": "45"
"model1408_4808-4.json": "20",
"model1408_4808-13.json": "38",
"model1408_4808-6.json": "24",
"model1408_4808-15.json": "42",
"model1109_3454.json": "1",
"model1408_4808-5-WSF.json": "21",
"model1408_4808-11.json": "34",
"model1208_2695-1.json": "2",
"model1408_4808-8-WSF.json": "27",
"model1408_4808-10.json": "32",
"model1408_4808-9.json": "30",
"model1408_4808-16.json": "44",
"model1408_4808-3.json": "18",
"model1408_4808-2.json": "16",
"model1408_4808-3-WSF.json": "17",
"model1212_2949-5.json": "8",
"model1408_4808-2-WSF.json": "15",
"model1408_4808-16-WSF.json": "43"
}

0 comments on commit 8dda8bb

Please sign in to comment.