Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More signatures for quotient_ring_as_module and ideal_as_module #4174

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Oct 3, 2024

Related to the discussion in PR #4100

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (78da753) to head (8823360).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4174   +/-   ##
=======================================
  Coverage   84.59%   84.59%           
=======================================
  Files         631      631           
  Lines       84813    84813           
=======================================
+ Hits        71747    71749    +2     
+ Misses      13066    13064    -2     
Files with missing lines Coverage Δ
src/Modules/ModulesGraded.jl 73.72% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a doctest for a MPolyLocalizedIdeal somewhere?

Copy link
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that we should eventually extend the tests a bit. Other than that, it seems good.

I was wondering whether it might make sense to have a unified name for the function, such as e.g. as_module(...). Similar to sub and friends. But we can discuss this some other time in person.

test/Modules/ModulesGraded.jl Outdated Show resolved Hide resolved
@wdecker wdecker enabled auto-merge (squash) October 4, 2024 10:30
@wdecker wdecker merged commit ca727c8 into master Oct 4, 2024
30 checks passed
@wdecker wdecker deleted the Wolfram branch October 4, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants