Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersect. Theory: Code cleanup, correction, new example #4180

Merged
merged 10 commits into from
Oct 7, 2024
Merged

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Oct 7, 2024

No description provided.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (1217ab3) to head (801aca3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4180      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         631      631              
  Lines       84811    84810       -1     
==========================================
- Hits        71751    71750       -1     
  Misses      13060    13060              
Files with missing lines Coverage Δ
...ental/IntersectionTheory/src/IntersectionTheory.jl 100.00% <ø> (ø)
experimental/IntersectionTheory/src/Main.jl 92.90% <100.00%> (ø)
experimental/IntersectionTheory/src/blowup.jl 98.47% <100.00%> (-0.02%) ⬇️

Copy link
Member

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some misc comments, mostly whitespace

experimental/IntersectionTheory/docs/src/intro.md Outdated Show resolved Hide resolved
experimental/IntersectionTheory/docs/src/intro.md Outdated Show resolved Hide resolved
experimental/IntersectionTheory/src/Main.jl Outdated Show resolved Hide resolved
experimental/IntersectionTheory/src/blowup.jl Outdated Show resolved Hide resolved
experimental/IntersectionTheory/src/blowup.jl Outdated Show resolved Hide resolved
experimental/IntersectionTheory/src/blowup.jl Outdated Show resolved Hide resolved
experimental/IntersectionTheory/src/blowup.jl Outdated Show resolved Hide resolved
wdecker and others added 6 commits October 7, 2024 15:46
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@thofma thofma enabled auto-merge (squash) October 7, 2024 14:14
@thofma thofma disabled auto-merge October 7, 2024 19:17
@thofma thofma merged commit c8a64e6 into master Oct 7, 2024
26 of 27 checks passed
@thofma thofma deleted the Wolfram branch October 7, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants