Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

two_neighbor_step without computing intersection numbers #4185

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

simonbrandhorst
Copy link
Collaborator

No description provided.

… sort basepoints of reducible fibers of elliptic surfaces
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 82.40000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (78da753) to head (d350e36).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
experimental/Schemes/src/elliptic_surface.jl 82.40% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4185      +/-   ##
==========================================
+ Coverage   84.59%   84.60%   +0.01%     
==========================================
  Files         631      631              
  Lines       84813    84951     +138     
==========================================
+ Hits        71747    71874     +127     
- Misses      13066    13077      +11     
Files with missing lines Coverage Δ
src/AlgebraicGeometry/Surfaces/K3Auto.jl 93.00% <ø> (ø)
experimental/Schemes/src/elliptic_surface.jl 86.05% <82.40%> (-0.19%) ⬇️

... and 17 files with indirect coverage changes

@simonbrandhorst
Copy link
Collaborator Author

Once #4189 is merged we should get a green test here also.

@simonbrandhorst simonbrandhorst enabled auto-merge (squash) October 9, 2024 14:31
@benlorenz benlorenz closed this Oct 9, 2024
auto-merge was automatically disabled October 9, 2024 16:30

Pull request was closed

@benlorenz benlorenz reopened this Oct 9, 2024
@simonbrandhorst simonbrandhorst enabled auto-merge (squash) October 10, 2024 05:02
@simonbrandhorst simonbrandhorst merged commit fd5741d into master Oct 10, 2024
59 of 60 checks passed
@simonbrandhorst simonbrandhorst deleted the sb/section_dec branch October 10, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants