Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Abelian groups docs #4186

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Oct 8, 2024

Similarly to the update in Hecke:
thofma/Hecke.jl#1631

(this is a copy of #4184, but this time not from a fork to get a preview)

preview: https://docs.oscar-system.org/previews/PR4186

Similarly to the update in Hecke:
thofma/Hecke.jl#1631
@lgoettgens lgoettgens added the documentation Improvements or additions to documentation label Oct 8, 2024
@lgoettgens
Copy link
Member Author

This is still broken, since I just cherry-picked the branch:
image

docs/doc.main Outdated Show resolved Hide resolved
@lgoettgens
Copy link
Member Author

I think the change in 4e95637 (#4186) makes it behave like in the Hecke navigation bar.

cc @paemurru

@lgoettgens
Copy link
Member Author

lgoettgens commented Oct 8, 2024

A local build now looks like this:
image
The preview should look the same (once the CI job finishes).

Is this what you imagined @paemurru ?

@lgoettgens lgoettgens requested a review from thofma October 8, 2024 13:26
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (4d1d833) to head (4e95637).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4186      +/-   ##
==========================================
- Coverage   84.59%   84.58%   -0.01%     
==========================================
  Files         631      631              
  Lines       84829    84829              
==========================================
- Hits        71758    71756       -2     
- Misses      13071    13073       +2     

see 1 file with indirect coverage changes

@thofma thofma enabled auto-merge (squash) October 9, 2024 06:55
@thofma thofma merged commit 759becf into master Oct 9, 2024
29 of 30 checks passed
@thofma thofma deleted the ep/add_missing_abelian_group_docs branch October 9, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants