add a missing in method
#4190
Merged
add a missing in method
#4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(According to the documentation, `hom(x) in A` shall return `false` for an element `x` of `A`, where `A` is a group of automorphisms.)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4190 +/- ##
=======================================
Coverage 84.58% 84.59%
=======================================
Files 631 631
Lines 84831 84832 +1
=======================================
+ Hits 71757 71760 +3
+ Misses 13074 13072 -2
|
fingolfin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation,
hom(x) in Ashall returnfalsefor an elementxofA, whereAis a group of automorphisms.With this addition, the proposed change from Nemocas/AbstractAlgebra.jl/pull/1853 should have less problems with the Oscar CI tests.
(There are of course missing
==methods in the Groups code of Oscar as soon as Nemocas/AbstractAlgebra.jl/pull/1853 becomes available, but I think some discussion is needed concerning how to fix this.)