Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informative error message for standard basis computation. #4204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HechtiDerLachs
Copy link
Collaborator

Address #4203 until we have more standard basis methods implemented.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.59%. Comparing base (24c8f63) to head (1d102a4).

Files with missing lines Patch % Lines
src/Modules/UngradedModules/SubquoModule.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4204      +/-   ##
==========================================
- Coverage   84.59%   84.59%   -0.01%     
==========================================
  Files         631      631              
  Lines       84906    84908       +2     
==========================================
  Hits        71830    71830              
- Misses      13076    13078       +2     
Files with missing lines Coverage Δ
src/Modules/UngradedModules/SubquoModule.jl 75.00% <50.00%> (-0.54%) ⬇️

@thofma
Copy link
Collaborator

thofma commented Oct 15, 2024

Did you check this this gives a different error message? As far as I see it will still crash in the default_ordering(M) call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants