Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1st shot at suppressing the Polymake banner in Oscar #247

Closed
wants to merge 2 commits into from
+3 −3
Closed

1st shot at suppressing the Polymake banner in Oscar #247

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49e2df8
1st shot at suppressing the Polymake banner in Oscar
fieker Apr 7, 2020
2ef17aa
add __is_root_module and use it to control banner
kalmarek Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Polymake.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,5 +115,8 @@ include("polynomial.jl")

include("polymake_direct_calls.jl")

include("generate_applications.jl")
Base.CoreLogging.with_logger(Base.CoreLogging.NullLogger()) do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a similar check here;
I like to see those when I'm using Polymake, but maybe I'm alone? @saschatimme, @benlorenz?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really care whether this is shown.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's get rid of this logging

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fieker instead of this, feel free to remove

Polymake.jl/src/generate_applications.jl

Line 14 in fd04c00

@info "Generating module $mod"

include("generate_applications.jl")
end

end # of module Polymake