Provide a stale_age to mkpidlock #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally the pidlock should be held for just a few seconds; waiting for its age to exceed 60 seconds until we consider it stale should be safe. In fact Julia waits 5 times longer if the process creating the pid lock file seems to be still running. On the other hand, without a stale age, the lock file is *never* considered stale, even if the process creating it definitely is gone, and so the user can get stuck, which obviously is very bad. To get unstuck they need to manually delete the lock file.
benlorenz
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
The time for the initialization is very hard to estimate, usually just a few seconds.
When there are many polymake wrappers to rebuild it might go over 5 min on a slow machine but that should be very rare (and I dont think anyone will run into issues with multiple processes in such an environment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the pidlock should be held for just a few seconds; waiting for
its age to exceed 60 seconds until we consider it stale should be safe.
In fact Julia waits 5 times longer if the process creating the pid lock
file seems to be still running.
On the other hand, without a stale age, the lock file is never
considered stale, even if the process creating it definitely is gone,
and so the user can get stuck, which obviously is very bad. To get
unstuck they need to manually delete the lock file.
Actually, I am not completely sure if the limit I provide is "good",
so if you think something else is more appropriate, please don't
hesitate to just adjust the PR or ask me to adjust it.