vdim: avoid overflow (#730)

oscar-system · Nov 22, 2023 · 3caa218 · 3caa218
1 parent 700dfbb
commit 3caa218
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/deps/src/ideals.cpp b/deps/src/ideals.cpp
@@ -563,7 +563,7 @@ void singular_define_ideals(jlcxx::Module & Singular)
  Singular.method("id_vdim", [](ideal I, ring r) {
  const ring origin = currRing;
  rChangeCurrRing(r);
- int n = scMult0Int(I, r->qideal);
+ long n = scMult0Int(I, r->qideal);
  rChangeCurrRing(origin);
  return n;
  });

diff --git a/src/ideal/ideal.jl b/src/ideal/ideal.jl
@@ -1240,7 +1240,7 @@ function vdim(I::sideal{S}) where {T <: Nemo.FieldElem,
  S <: Union{spoly{T}, spluralg{T}}}
  I.isGB || error("Not a Groebner basis")
  R = base_ring(I)
- GC.@preserve I R return Int(libSingular.id_vdim(I.ptr, R.ptr))
+ GC.@preserve I R return Int64(libSingular.id_vdim(I.ptr, R.ptr))
 end
 
 @doc raw"""

diff --git a/src/module/module.jl b/src/module/module.jl
@@ -611,7 +611,7 @@ end
 function vdim(I::smodule)
  I.isGB || error("Not a Groebner basis")
  R = base_ring(I)
- GC.@preserve I R return Int(libSingular.id_vdim(I.ptr, R.ptr))
+ GC.@preserve I R return Int64(libSingular.id_vdim(I.ptr, R.ptr))
 end
 
 ###############################################################################