Merge branch 'master' into lr/dev

.github/workflows/CI.yml

@@ -7,6 +7,9 @@ on:
  - 'release-*'
  tags: '*'
  pull_request:
+ schedule:
+ # Every day at 3:00 AM UTC (Tutorial tests initiated at 2:00AM)
+ - cron: '0 3 * * *'
 
 concurrency:
  # group by workflow and ref; the last slightly strange component ensures that for pull

.github/workflows/oscar.yml

@@ -7,6 +7,9 @@ on:
  pull_request:
  branches:
  - master
+ schedule:
+ # Every day at 3:00 AM UTC (Tutorial tests initiated at 2:00AM)
+ - cron: '0 3 * * *'
 
 concurrency:
  # group by workflow and ref; the last slightly strange component ensures that for pull

Project.toml

@@ -1,6 +1,6 @@
 name = "Singular"
 uuid = "bcd08a7b-43d2-5ff7-b6d4-c458787f915c"
-version = "0.23.4"
+version = "0.23.5"
 
 [deps]
 AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
@@ -29,8 +29,8 @@ Pidfile = "1.3"
 Pkg = "1.6"
 Random = "1.6"
 RandomExtensions = "0.4.2"
-Singular_jll = "~404.000.100"
+Singular_jll = "~404.000.504"
 Statistics = "1.6"
 julia = "1.6"
 lib4ti2_jll = "1.6.10"
-libsingular_julia_jll = "~0.45.2"
+libsingular_julia_jll = "~0.45.4"

src/map/alghom.jl

@@ -35,8 +35,26 @@ function map_ideal(f::Map(SAlgHom), I::sideal)
  algebra homomorphism.")
  end
 
- GC.@preserve I f return Ideal(f.codomain, libSingular.maMapIdeal(I.ptr, f.domain.ptr,
- f.ptr, f.codomain.ptr, libSingular.ndCopyMap()))
+ ptr = GC.@preserve I f libSingular.maMapIdeal(I.ptr, f.domain.ptr,
+ f.ptr, f.codomain.ptr, libSingular.ndCopyMap())
+
+ J = Ideal(f.codomain,ptr)
+ # compare the orderings of f.domain.ptr and f.codomain.ptr
+ domain_ord=Cint[]
+ libSingular.rOrdering_helper(domain_ord, f.domain.ptr)
+ codomain_ord=Cint[]
+ libSingular.rOrdering_helper(codomain_ord, f.codomain.ptr)
+ equal_ordering=true
+ for i in 1:size(domain_ord,1)
+ if domain_ord[i] != codomain_ord[i]
+ equal_ordering=false
+ break
+ end
+ end
+ if equal_ordering
+ J.isGB = I.isGB
+ end
+ return J
 end
 
 function map_poly(f::Map(SAlgHom), p::spoly)