rename orderings: revlex->invlex,rp->ip...introduce deginvlex #722
Conversation
|
Should we really do this here? It's a breaking change, and it is not really necessary for Oscar as far as I can tell (we don't expose the names used by Singular.jl in Oscar, do we?). And arguably it makes sense for Singular.jl to use the same names as Singular does... |
Project.toml
Outdated
| Statistics = "1.6" | ||
| julia = "1.6" | ||
| lib4ti2_jll = "1.6.10" | ||
| libsingular_julia_jll = "~0.40.5" | ||
| libsingular_julia_jll = "~0.40.6" |
There was a problem hiding this comment.
Maybe we should first apply this in a separate PR, merge that and make a release?
There was a problem hiding this comment.
I think we need to discuss this some more. Hopefully @wdecker can also comment.
Let me emphasize that this is really independent of the discussion about how to name monomial ordering in Oscar: The Oscar names are completely independent from the names in Singular.jl. If we change names in Singular.jl, that just causes more work on the Oscar side. That means: if you really want it, we can do it; but otherwise I'd rather keep the names here and focus on improving Oscar.
| @@ -81,13 +81,14 @@ JLCXX_MODULE define_julia_module(jlcxx::Module & Singular) | |||
| /* monomial orderings */ | |||
| Singular.set_const("ringorder_no", ringorder_no); | |||
| Singular.set_const("ringorder_lp", ringorder_lp); | |||
| Singular.set_const("ringorder_rp", ringorder_rp); | |||
| Singular.set_const("ringorder_ip", ringorder_ip); | |||
There was a problem hiding this comment.
But the order is called "rp" in Singular, isn't it? If so, I don't support this part of the PR. Same for rs -> is.
That leaves the addition of Ip. Is that what it is called in Singular? Or is it perhaps Rp there? Whatever it is, we should use the name used in Singular here.
@wdecker please comment if you disagree
There was a problem hiding this comment.
I am confused: AFAIK the naming convention should also be changed inside Singular itself. So in order to have Singular.jl coincide with Singular these changes should be done, right?
There was a problem hiding this comment.
The orderings in Singular are 1- or 2-letter-codes, names appear only in the manual.
In Singular.jl main orderings are denoted by names (like :degrevlex).
The orderings in question (in Singular: rp/rs) have a warning in the manual
(only introduced to make "opposite ring" possible).
The ordering "deginvlex" (Ip in Singular) is new - so here we are completely free with the naming.
fingolfin
force-pushed
the
hs/orderings
branch
from
be0b73e
to
8909634
Compare
src/poly/orderings.jl
Outdated
| ordering_Ip(nvars::Int = 1) | ||
|
|
||
| Represents a block of at least `nvars` variables with the | ||
| degree inverse lexicographical ordering (:deginvlex). |
There was a problem hiding this comment.
Maybe adjust this docstring, too?
src/poly/orderings.jl
Outdated
| ordering_is(nvars::Int = 1) | ||
|
|
||
| Represents a block of at least `nvars` variables with the | ||
| negative inverse lexicographical ordering (:neginvlex). |
There was a problem hiding this comment.
Maybe adjust this docstring, too?
fingolfin
force-pushed
the
hs/orderings
branch
from
8909634
to
3cc7f7b
Compare
|
Rebased this, and changed the version to 0.20.0-DEV, as the change in here is breaking. |
currently we have both: ordering_ip and ordering_rp (also is/rs). The description refers to the upcoming naming (invlex/ip)
No description provided.