Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libsingular_julia: id_prune_map_v #740

Merged
merged 10 commits into from
Jan 10, 2024
Merged

libsingular_julia: id_prune_map_v #740

Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4cc8b96
libsingular_julia: id_prune_map_v
hannes14 Dec 17, 2023
1318656
extern ideal idMinEmbedding_with_map_v(ideal arg,intvec **w, ideal &t…
hannes14 Dec 17, 2023
6c2186d
Singular version
hannes14 Dec 17, 2023
5ef7147
version of libsingular_julia nand Singular_jll
hannes14 Dec 20, 2023
4316caf
Update Project.toml
fingolfin Dec 21, 2023
eab4ca9
Merge branch 'master' into hs/libsingular_prune
fingolfin Dec 21, 2023
5fcbe6b
Version 0.21.1
fingolfin Dec 21, 2023
f91cdf2
Restore CMakeLists.txt tweak
fingolfin Dec 21, 2023
ec472a4
add id_prune_map, id_prune_map_v
hannes14 Dec 22, 2023
cc96944
Merge branch 'master' into hs/libsingular_prune
fingolfin Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions deps/src/ideals.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,17 +89,6 @@ auto id_mres_map_helper(sip_sideal * I, int n, ring R)
return std::make_tuple(s, TT);
}

auto id_prune_map_helper(sip_sideal * I, ring R)
{
auto origin = currRing;
rChangeCurrRing(R);
ideal T;
ideal s = idMinEmbedding_with_map(I, NULL, T);
matrix TT = id_Module2Matrix(T, currRing);
rChangeCurrRing(origin);
return std::make_tuple(s, TT);
}

ideal id_Syzygies_internal(ideal m, ring o)
{
ideal id = NULL;
Expand Down Expand Up @@ -404,7 +393,6 @@ void singular_define_ideals(jlcxx::Module & Singular)

Singular.method("id_res", &id_res_helper);
Singular.method("id_mres_map", &id_mres_map_helper);
Singular.method("id_prune_map", &id_prune_map_helper);
hannes14 marked this conversation as resolved.
Show resolved Hide resolved

Singular.method("id_Slimgb", &id_Slimgb_helper);

Expand Down Expand Up @@ -563,7 +551,7 @@ void singular_define_ideals(jlcxx::Module & Singular)
Singular.method("id_vdim", [](ideal I, ring r) {
const ring origin = currRing;
rChangeCurrRing(r);
long n = scMult0Int(I, r->qideal);
int n = scMult0Int(I, r->qideal);
rChangeCurrRing(origin);
return n;
});
Expand Down
Loading