Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JLL deps #741

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Update JLL deps #741

merged 3 commits into from
Dec 21, 2023

Conversation

fingolfin
Copy link
Member

Unfortunately tests fail:

...
Test Summary:             | Pass  Total  Time
smodule.divrem and reduce |    3      3  0.0s
smodule.prune: Error During Test at /Users/mhorn/Projekte/OSCAR/Singular.jl/test/module/smodule-test.jl:324
  Test threw exception
  Expression: G[1] == vector(R, z)
  Vectors of incompatible rank
  Stacktrace:
   [1] error(s::String)
     @ Base ./error.jl:35
   [2] check_parent
     @ ~/Projekte/OSCAR/Singular.jl/src/module/vector.jl:54 [inlined]
   [3] ==(x::svector{spoly{n_Q}}, y::svector{spoly{n_Q}})
     @ Singular ~/Projekte/OSCAR/Singular.jl/src/module/vector.jl:163
   [4] eval_test(evaluated::Expr, quoted::Expr, source::LineNumberNode, negate::Bool)
     @ Test ~/.julia/juliaup/julia-1.9.4+0.aarch64.apple.darwin14/share/julia/stdlib/v1.9/Test/src/Test.jl:321
   [5] macro expansion
     @ ~/.julia/juliaup/julia-1.9.4+0.aarch64.apple.darwin14/share/julia/stdlib/v1.9/Test/src/Test.jl:478 [inlined]
   [6] macro expansion
     @ ~/Projekte/OSCAR/Singular.jl/test/module/smodule-test.jl:324 [inlined]
   [7] macro expansion
     @ ~/.julia/juliaup/julia-1.9.4+0.aarch64.apple.darwin14/share/julia/stdlib/v1.9/Test/src/Test.jl:1498 [inlined]
   [8] top-level scope
     @ ~/Projekte/OSCAR/Singular.jl/test/module/smodule-test.jl:311
Test Summary: | Pass  Error  Total  Time
smodule.prune |    2      1      3  0.4s
ERROR: LoadError: Some tests did not pass: 2 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /Users/mhorn/Projekte/OSCAR/Singular.jl/test/module/smodule-test.jl:310
in expression starting at /Users/mhorn/Projekte/OSCAR/Singular.jl/test/module-test.jl:2
in expression starting at /Users/mhorn/Projekte/OSCAR/Singular.jl/test/runtests.jl:21
ERROR: Package Singular errored during testing

The failing test is this:

   R, (x, y, z) = polynomial_ring(QQ, ["x", "y", "z"])

   v1 = vector(R, R(1),R(0),R(0))
   v2 = vector(R, x,R(0),R(0))
   v3 = vector(R, R(0),z,R(0))
   v4 = vector(R, R(0),R(0),R(1))

   M = Singular.Module(R, v1, v2, v3, v4)

   G,T = prune_with_map(M)

   @test ngens(G) == 1

   @test G[1] == vector(R, z)     # <-- this fails

Trying this code interactively, I see this:

...
julia> G[1]
z*gen(2)

julia> vector(R, z)
z*gen(1)

Could this be an off-by-one error caused by the recent array changes, @benlorenz ?

Or something that changed in Singular, @hannes14 ?

@benlorenz
Copy link
Member

We do have two new JLLs, the first one (0.40.8) only contains the Singular_jll bump, but not the new libsingular_julia code. Pinning that version (and disabling the automatic compilation) I still get the same error, so I would think this is caused by something in Singular. (Also we did not see this in the CI on master when the libjulia / array changes were merged)

@fingolfin
Copy link
Member Author

@benlorenz thanks that makes sense

Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
@fingolfin fingolfin enabled auto-merge (squash) December 21, 2023 16:31
@fingolfin fingolfin merged commit 94b5281 into oscar-system:master Dec 21, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants