libsingular: don't autobuild for released versions #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the uuid might not appear in the dependencies when singular is the active project
fingolfin
reviewed
Jan 10, 2024
fingolfin
approved these changes
Jan 10, 2024
Co-authored-by: Max Horn <max@quendi.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_tracking_registryis true when it is neither loaded from a path (]dev) nor via a direct repository access (e.g.]add Singular#somecommit). So in other words when it is a released version installed as a normal dependency package.In this case we assume that the jll works and just load that.
We could also add a check for cmake but I think this should be fine like this.
See: #735
cc: @thofma @fingolfin
Tree-hash check is now green again with the new 0.40.9+1 jll from JuliaPackaging/Yggdrasil#7910. This also works for the current 0.21.2 release.