CI: always test treehash mismatch handling code path #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the one hand, this helps ensure it doesn't get broken. On the other hand it avoids or at least reduces code coverage fluctuations that happen when we switch from a situation with a treehash mismatch (which thus tests that code path) to one without a treehash mismatch (which does not test it) when updating libsingular_julia_jll.
fingolfin
force-pushed
the
mh/treehash-codecoverage
branch
from
6f1cfbf
to
374a773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the one hand, this helps ensure it doesn't get broken. On the other
hand it avoids or at least reduces code coverage fluctuations that
happen when we switch from a situation with a treehash mismatch (which
thus tests that code path) to one without a treehash mismatch (which
does not test it) when updating libsingular_julia_jll.