Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a stale_age to mkpidlock #815

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Provide a stale_age to mkpidlock #815

merged 1 commit into from
Jul 19, 2024

Conversation

fingolfin
Copy link
Member

Normally the pidlock should be held for just a few seconds;
waiting for its age to exceed 60 seconds until we consider it stale
should be very safe. In fact Julia waits 5 times longer if the
process creating the pid lock file seems to be still running.

On the other hand, without a stale age, the lock file is never
considered stale, even if the process creating it definitely is gone,
and so the user can get stuck, which obviously is very bad. To
get unstuck they need to manually delete the lock file.

Normally the pidlock should be held for just a few seconds;
waiting for its age to exceed 60 seconds until we consider it stale
should be very safe. In fact Julia waits 5 times longer if the
process creating the pid lock file seems to be still running.

On the other hand, without a stale age, the lock file is *never*
considered stale, even if the process creating it definitely is gone,
and so the user can get stuck, which obviously is very bad. To
get unstuck they need to manually delete the lock file.
@fingolfin fingolfin merged commit ac6d9d0 into master Jul 19, 2024
14 checks passed
@fingolfin fingolfin deleted the mh/mkpidlock branch July 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant