pull changes from bugfix PR

osmosis-labs · Mar 30, 2024 · 1511cd3 · 1511cd3
1 parent ed41043
commit 1511cd3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/contracts/sumtree-orderbook/src/sumtree/node.rs b/contracts/sumtree-orderbook/src/sumtree/node.rs
@@ -363,7 +363,7 @@ impl TreeNode {
         let is_left_internal = maybe_left.clone().map_or(false, |l| l.is_internal());
         let is_right_internal = maybe_right.clone().map_or(false, |r| r.is_internal());
         let is_in_left_range = maybe_left.clone().map_or(false, |left| {
-            new_node.get_min_range() <= left.get_max_range()
+            new_node.get_min_range() < left.get_max_range()
         });
         let is_in_right_range = maybe_right.clone().map_or(false, |right| {
             new_node.get_min_range() >= right.get_min_range()

diff --git a/contracts/sumtree-orderbook/src/sumtree/test/test_node.rs b/contracts/sumtree-orderbook/src/sumtree/test/test_node.rs
@@ -248,6 +248,16 @@ fn test_node_insert_valid() {
             expected: vec![1, 5, 2, 4, 7, 3, 6],
             print: true,
         },
+        TestNodeInsertCase {
+            name: "Insert sequential nodes",
+            nodes: vec![
+                NodeType::leaf_uint256(5u128, 10u128),
+                NodeType::leaf_uint256(15u128, 20u128),
+                NodeType::leaf_uint256(35u128, 30u128),
+            ],
+            expected: vec![1, 2, 5, 3, 4],
+            print: true,
+        },
     ];
 
     for test in test_cases {