Improve compile time #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Signed-off-by: Yadunund <yadunund@openrobotics.org>
Yadunund
force-pushed
the
yadu/improve_compile_time
branch
from
0c22186
to
1ae7378
Compare
mjcarroll
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out passing libraries to link in
target_link_libraries()as${foo_pkg_LIBRARIES}introduces a lot of duplicate of the same library that needs to be linked. This the reason why theldlinker takes a REALLY long time to finish linking since it does not de-duplicate the duplicate libraries and links all them. Thelldlinker seems to be smarter about this.Switching to
${foo_pkg_TARGETS}prevents the duplicate libraries that were previously included as transitives. This is also the pattern that ROS 2 follows. See.With these changes, I can compile the workspace faster than ever with just
ld.I removed the need to install and use
lldin the README so that users can follow regular ROS patterns to build the workspace. But kept it in CI so that i can be faster since at the end of the daylldwith these changes is faster thanlldwithout these changes.