Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear pg_store_plans Development Team,
I am pleased to submit this pull request, which brings forward compatibility updates and enhancements for PostgreSQL version 16.1, along with modifications for better support when building with
cassert
. Below, I have detailed the key changes made:Conditional Compilation Adaptation for PostgreSQL 16.1:
pg_store_plans.c
. These modifications extend support to PostgreSQL 16.1, ensuring the codebase remains compatible with the latest PostgreSQL version.Header File Path Adjustments for PostgreSQL 16.1:
#include "nodes/queryjumble.h"
), aligning with the changes in PostgreSQL 16.1’s directory structure and APIs.Variable Initializations for cassert Compatibility:
track_level
,plan_format
, andplan_storage
). These were previously uninitialized, potentially causing issues when building withcassert
, as it necessitates all variables to be initialized to ensure robust error checking. I have set their default values to1
, aligning with the expected default behavior of the system.cassert
is commonly enabled, and ensures predictable behavior across different builds and environments.JSON and YAML Processing Function Modifications:
Cleaning Up Outdated Conditional Compilations:
The primary motivation behind these changes is to ensure that
pg_store_plans
stays up-to-date with the latest PostgreSQL release, while also addressing build compatibility issues when usingcassert
. This will not only benefit environments where strict error checking is required but also contribute to the overall reliability of the software.I hope these updates will be valuable to the
pg_store_plans
project, and I am keen to discuss any aspects of this pull request or make further modifications if required.Thank you for considering these enhancements.
Best regards,
Lev Nikolaev,
Tantor Labs