feat(linter): expand package checks across multiple ecosystems #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogo6002
force-pushed
the
add_ecosystem_check
branch
from
93867dc to
8d88472
Compare
oliverchang
reviewed
Dec 17, 2024
Signed-off-by: Holly Gong <gongh@google.com>
Signed-off-by: Holly Gong <gongh@google.com>
Signed-off-by: Holly Gong <gongh@google.com>
Signed-off-by: Holly Gong <gongh@google.com>
hogo6002
force-pushed
the
add_ecosystem_check
branch
from
730f1e5 to
b91e4e3
Compare
andrewpollock
approved these changes
Dec 23, 2024
| } | ||
|
|
||
| // EcosystemBaseURLs maps ecosystems to their base API URLs. | ||
| var EcosystemBaseURLs = map[string]string{ |
There was a problem hiding this comment.
There's an opportunity to DRY this out a bit, and we can use the keys of EcosystemBaseURLs to infer what is now duplicated into SupportedEcosystems.
| return true | ||
| } | ||
|
|
||
| // Needs to use GET instead of HEAD for Maven |
There was a problem hiding this comment.
Please also add why to this comment
Suggested change
| // Needs to use GET instead of HEAD for Maven | |
| // Needs to use GET instead of HEAD for Maven. |
There was a problem hiding this comment.
There's a lot of (understandably valid) inconsistency to the implementation of the functions in this package. To assist with contributions, please add a package docstring that explains the goals of functions in this package and provides a canonical example that contributors can crib from, to avoid getting cargo-culted contributions from a non-canonical function implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the linter by adding package existence checks for a variety of ecosystems:
To accommodate these additions, the
ecosystems.gofile has been refactored, with code related to package existence checks moved topackage_check.goand version checks moved toversion_check.go.A current limitation is that malicious package record validation may fail, as these packages are often removed from package registries and are no longer queryable via API.