Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live activity dismissal_date key support #126

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

crafterm
Copy link
Contributor

@crafterm crafterm commented Oct 9, 2023

This PR adds support for the dismissal_date key that allows one to specify a time when a live activity should be removed from the dynamic island and/or lock screen as per Apple's docs.

Updated specs to validate and README to document.

@crafterm
Copy link
Contributor Author

crafterm commented Oct 16, 2023

cc @benubois @ostinelli - followup to my previous live activity related PR adding in one missing key - thanks for your consideration, hope all is well team 🙏

@ostinelli
Copy link
Owner

Hey @crafterm thans for your input. Will take a look asap.

@crafterm
Copy link
Contributor Author

Hi @ostinelli - just a friendly ping on this one, keen to update to an official release of the gem soon 🙏

@ostinelli ostinelli merged commit 4b0f851 into ostinelli:master Apr 10, 2024
7 checks passed
@ostinelli
Copy link
Owner

ostinelli commented Apr 10, 2024

Thank you, pushed in 1.7.2.

@crafterm crafterm deleted the feature/dismissal_date branch May 20, 2024 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants