Merge branch 'dev'

CHANGELOG.md

@@ -2,6 +2,23 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+# [0.4.0](https://github.com/ottomatica/opunit/compare/v0.3.2...v0.4.0) (2019-05-06)
+
+
+### Bug Fixes
+
+* Fix reachable check for directories ([8f3e812](https://github.com/ottomatica/opunit/commit/8f3e812))
+* **checks:** Fixes conditional statement in reachable check ([2aaf6c7](https://github.com/ottomatica/opunit/commit/2aaf6c7))
+* **checks:** reachable check should use status of last redirect ([5b83f98](https://github.com/ottomatica/opunit/commit/5b83f98))
+* **reachable:** parses redirected headers and searches for 200 ok ([#80](https://github.com/ottomatica/opunit/issues/80)) ([35e986d](https://github.com/ottomatica/opunit/commit/35e986d))
+
+
+### Features
+
+* Exit code = 1 when any checks fail ([50fb273](https://github.com/ottomatica/opunit/commit/50fb273))
+
+
+
 <a name="0.3.2"></a>
 ## [0.3.2](https://github.com/ottomatica/opunit/compare/v0.3.1...v0.3.2) (2019-02-07)
 

lib/harness/ssh.js

@@ -121,16 +121,17 @@ class SSHConnector {
 
     async isReachable(host, context) {
         let output = (await this.exec(context, `ping -c 3 ${host}`));
-        if (!(output.includes('nknown host') || output.includes('cannot resolve'))) {
+        if (!(output.includes('nknown host') || !output.includes('cannot resolve'))) {
             // Domain checks out
             return true;
         }
         // Url is reachable
-        return (await this.exec(context, `curl -Is ${host} | head -1`)).includes('200 OK');
+        // See: https://stackoverflow.com/questions/10060098/getting-only-response-header-from-http-post-using-curl , https://stackoverflow.com/questions/47080853/show-the-final-redirect-headers-using-curl
+        return (await this.exec(context, `curl -sL -D - ${host} -o /dev/null | grep 'HTTP/1.1' | tail -1`)).includes('200 OK');
     }
 
     async pathExists(path, context) {
-        return (await this.exec(context, `[ ! -f ${path} ] || echo 'file exists'`)).includes('file exists');
+        return (await this.exec(context, `[ ! -e ${path} ] || echo 'file exists'`)).includes('file exists');
     }
 
     async contains(context, file, string, expect = true) {

lib/inspect/report.js

@@ -1,5 +1,6 @@
 
 const chalk = require('chalk');
+const process = require('process');
 const os    = require('os');
 
 class Reporter {
@@ -27,6 +28,9 @@ class Reporter {
         } else {
             let overallPassRate = (this.passed / this.total * 100.0).toFixed(1);
 
+            // set exitCode to 1 if anything failed
+            if (this.failed > 0) process.exitCode = 1;
+
             console.log();
             console.log(chalk.underline('Summary'));
             console.log();