Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
- githubnext#21 githubnext#37 "Hanging Font": Miss configure `typo` and `hhea` value. Adjust this value will "centering" glyphs across the vertical bounding box.

- githubnext#169  Probably same as above, tweaking `typo` and `hhea` does resolve the `line-height` or `leading` default to `1.2` or `120%` from the upm value.

UPM = 2000
(typo/hhea)Ascenders = 1930
(typo/hhea)Descenders = -470
(typo/hhea)LineGap = 0

Total:
ascender + abs(descenders) + linegap = 2400

Note that "Gcommaaccent" may be truncated in environments that have `overflow: hidden`

Please see these documentation:
- https://googlefonts.github.io/gf-guide/metrics.html#6-winascent-and-windescent-values-must-be-the-same-as-the-familys-tallestdeepest-ymin-and-ymax-bounding-box-values
- https://googlefonts.github.io/gf-guide/metrics.html#11-the-sum-of-the-fonts-vertical-metric-values-absolute-should-be-20-30-greater-than-the-fonts-upm
  • Loading branch information
ottta committed May 26, 2024
1 parent 7da07ce commit d68bcf3
Show file tree
Hide file tree
Showing 10 changed files with 494 additions and 480 deletions.
104 changes: 56 additions & 48 deletions sources/Monaspace Argon Var.glyphs
Original file line number Diff line number Diff line change
Expand Up @@ -1260,27 +1260,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1331,27 +1331,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1401,27 +1401,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1471,27 +1471,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand All @@ -1502,6 +1502,14 @@ name = winDescent;
value = 786;
}
);
guides = (
{
pos = (83,1930);
},
{
pos = (19,-470);
}
);
id = "05608152-0947-468D-8C2A-07D081228424";
metricValues = (
{
Expand Down Expand Up @@ -1541,27 +1549,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1613,27 +1621,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1684,27 +1692,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down Expand Up @@ -1755,27 +1763,27 @@ axesValues = (
customParameters = (
{
name = hheaAscender;
value = 1565;
value = 1930;
},
{
name = hheaDescender;
value = -435;
value = -470;
},
{
name = typoAscender;
value = 1565;
value = 1930;
},
{
name = typoDescender;
value = -435;
value = -470;
},
{
name = typoLineGap;
value = 400;
value = 0;
},
{
name = hheaLineGap;
value = 400;
value = 0;
},
{
name = winAscent;
Expand Down
Loading

0 comments on commit d68bcf3

Please sign in to comment.