Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contract source and typescript source in export #124

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Jun 27, 2023

Added the improvements from 1155's pr: ourzora/zora-protocol#108

  • contract source code, addresses json, and config json are now bundled with the package, in the folder /src and /addresses and /chainConfigs correspondingly.
  • You can now go to directly the typescript source file when going to definition instead of the type declaration file.. This is achieved by running the post build step tsc --emitDeclarationOnly --declaration --declarationMap, documented here
  • tsup config moved to tsup.config.ts

Additionally, moved the "output" folder for foundry back to "out" - not the dist folder. If we seed the need to include that in the export we can.

clean: true,
dts: false,
format: ['cjs'],
onSuccess: 'tsc --emitDeclarationOnly --declaration --declarationMap'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allows the source code files to have "go to definition" on package impor

Copy link
Collaborator

@iainnash iainnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks :)

@oveddan oveddan merged commit 9650357 into main Jun 28, 2023
2 checks passed
@oveddan oveddan deleted the improved-package-bundling branch June 28, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants