Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use hash instead of url for primary cache key #102

Merged
merged 5 commits into from
Oct 4, 2024
Merged

fix: use hash instead of url for primary cache key #102

merged 5 commits into from
Oct 4, 2024

Conversation

ghost
Copy link

@ghost ghost commented Sep 29, 2024 •
edited by xhyrom
Loading

its not working when cache key is URL (because of url unsafe characters or smth i think), so i suggest to hash download url and use it as cache key

fixes #101

@xhyrom xhyrom changed the title fix: cache in gitea/forgejo actions (closes #101) fix: cache in gitea/forgejo actions Sep 29, 2024
@autofix-ci autofix.ci
Copy link
Contributor

autofix-ci bot commented Sep 29, 2024

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@xhyrom xhyrom changed the title fix: cache in gitea/forgejo actions fix: use hash instead of url for primary cache key Sep 29, 2024
xhyrom
xhyrom requested changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow autofix

@ghost ghost requested a review from xhyrom September 29, 2024 19:56
@ghost
Copy link
Author

ghost commented Oct 4, 2024

@xhyrom ?

xhyrom
xhyrom approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I forgot sorry 😅

@ghost
Copy link
Author

ghost commented Oct 4, 2024

i cant allow edits from maintainers because its cross-org fork (https://github.com/orgs/community/discussions/5634)
but i ran format and build scripts, so there cant be a problem here?

@xhyrom xhyrom changed the base branch from main to dev October 4, 2024 20:28
@xhyrom
Copy link
Collaborator

xhyrom commented Oct 4, 2024 •
edited
Loading

I'll move it to the dev branch and then create PR from dev -> main. Thanks!

@xhyrom xhyrom merged commit e44c52a into oven-sh:dev Oct 4, 2024
31 of 44 checks passed
xhyrom added a commit that referenced this pull request Oct 8, 2024
@xhyrom @autofix-ci
fix: use hash instead of url for primary cache key (#102) (#103)
a8913c4 
* fix: use hash instead of url for primary cache key (#102)

* Update cache-save.ts

* Update action.ts

* Update cache-save.ts

* build

* format

* [autofix.ci] apply automated fixes

---------

Co-authored-by: Daniil Zotov <142039751+zoto-ff@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cache is not working in gitea/forgejo
1 participant
@xhyrom