Add auth setup for private registry with scope #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerocowl
reviewed
Sep 9, 2023
CyberFlameGO
suggested changes
Sep 23, 2023
|
There are some conflicts, can you resolve them? |
vitoorgomes
force-pushed
the
feature/add-authentication-setup-to-private-registries-with-scope
branch
from
d3f5622
to
3f00658
Compare
when I forked |
didn't had free time sooner, but it's done |
|
can you rebuild it one more time, please? Then ping me, i'll merge. |
vitoorgomes
force-pushed
the
feature/add-authentication-setup-to-private-registries-with-scope
branch
from
3f00658
to
345d8f9
Compare
sure, done |
xhyrom
approved these changes
Nov 1, 2023
vitoorgomes
deleted the
feature/add-authentication-setup-to-private-registries-with-scope
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bun is awesome, but I've seen too many workarounds to make authentication for a private package under a registry-url (like
'https://npm.pkg.github.com/') with a scopeHeavily inspired by the
setup-nodeaction, I created this to support this featureI've tested a lot on a private personal org with a private package and my repo that installs the private package on CI worked like a charm.
Also
"@actions/cache"import was duplicated onsetup.tsand now I left onlyimport * as cache from "@actions/cache";