feat: Merge local bunfig with action scope/registry config #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitoorgomes
force-pushed
the
feat/merge-local-bunfig-with-scope-action
branch
from
d7922f5
to
8c0b797
Compare
|
Thanks you for this! |
API must be fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auth is now able to merge local config with the necessary scope + registry url without duplicating or doing some weird things when a local config already exists.
It covers:
bunfig.tomlbunfig.tomldoes not have any[install.scopes]bunfig.tomldoes have a[install.scopes]and it's not the same as the actionbunfig.tomldoes have a[install.scopes]and it's the same as the actionIt will be able to merge all without conflicting keys
#33
I also created some tests and added to the github actions as a new step