Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package manager #42

Merged
merged 10 commits into from
Dec 3, 2023
Merged

fix: package manager #42

merged 10 commits into from
Dec 3, 2023

Conversation

xhyrom
Copy link
Collaborator

@xhyrom xhyrom commented Nov 26, 2023

  • tests

@xhyrom
Copy link
Collaborator Author

xhyrom commented Nov 26, 2023

I'll merge it yesterday, want to do better tests in GH action

@jord1e
Copy link

jord1e commented Nov 26, 2023

Thanks, Please implement this at the same time, two birds one stone ;)

image

because it is split on bun@[1] it will continue to work but you can use npm run and yarn run if you only use bun for bun install

And Im a bit unsure if removing the default will just make it work, I think keeping the default but using the fix I proposed in #40 is better as it still works without specifying a version anywhere

@xhyrom
Copy link
Collaborator Author

xhyrom commented Nov 27, 2023

Thanks, Please implement this at the same time, two birds one stone ;)

image

because it is split on bun@[1] it will continue to work but you can use npm run and yarn run if you only use bun for bun install

And Im a bit unsure if removing the default will just make it work, I think keeping the default but using the fix I proposed in #40 is better as it still works without specifying a version anywhere

👍🏾 Also, removing default value should work, that's how @actions/core works https://github.com/actions/toolkit/blob/master/packages/core/src/core.ts#L71 but I'll implement better tests before merging

@xhyrom xhyrom merged commit c0059f0 into main Dec 3, 2023
24 checks passed
@xhyrom xhyrom deleted the xHyroM/fix/package-manager branch December 3, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants