Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow more spaces for .tool-versions #94

Merged
merged 2 commits into from
Jul 30, 2024
Merged

fix: allow more spaces for .tool-versions #94

merged 2 commits into from
Jul 30, 2024

Conversation

ronnnnn
Copy link
Contributor

@ronnnnn ronnnnn commented Jul 30, 2024 •
edited
Loading

Overview

Correctly read the 'bun' version if .tool-versions contains two or more spaces between 'bun' and the version number.

Use Case

This change is necessary when .tool-versions may appear in the following format:

node 20.12.2
bun  1.1.20

@xhyrom xhyrom changed the title update: allow more spaces for .tool-versions fix: allow more spaces for .tool-versions Jul 30, 2024
@xhyrom
Copy link
Collaborator

xhyrom commented Jul 30, 2024

thanks for you contribution

@xhyrom xhyrom merged commit 1e54087 into oven-sh:main Jul 30, 2024
32 of 44 checks passed
@ronnnnn ronnnnn deleted the update-allow-more-spaces-for-tool-versions branch July 31, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhyrom xhyrom xhyrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronnnnn @xhyrom