Fix empty class usage #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overfl0
reviewed
Sep 10, 2019
| self.next() | ||
| self.parseWhitespace() | ||
| self.parsePropertyName() | ||
| self.parseWhitespace() | ||
|
|
||
|
|
||
| current = self.current() | ||
|
|
||
There was a problem hiding this comment.
You need to remove the trailing spaces here
overfl0
reviewed
Jan 28, 2020
| elif current == SEMICOLON: | ||
| value = self.dict() | ||
| self.parseWhitespace() | ||
|
|
There was a problem hiding this comment.
Any chance you could add a test for this case? I'm slowly starting to think about merging this ;)
|
https://www.youtube.com/watch?v=Vyw6n1EKlww Good morning! Nice day for adding tests, isn't it? 😀 |
|
Hey, @Adanteh! maybe you've changed your mind 3 years later? 🤔 |
|
Are you still wanting to test this? |
|
I have rewritten Adanteh's code myself and added my own tests instead of reusing his PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.