-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty class usage #2
base: master
Are you sure you want to change the base?
Conversation
self.next() | ||
self.parseWhitespace() | ||
self.parsePropertyName() | ||
self.parseWhitespace() | ||
|
||
|
||
current = self.current() | ||
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove the trailing spaces here
elif current == SEMICOLON: | ||
value = self.dict() | ||
self.parseWhitespace() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could add a test for this case? I'm slowly starting to think about merging this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahem! ;)
https://www.youtube.com/watch?v=Vyw6n1EKlww Good morning! Nice day for adding tests, isn't it? 😀 |
Hey, @Adanteh! maybe you've changed your mind 3 years later? 🤔 |
Are you still wanting to test this? |
I have rewritten Adanteh's code myself and added my own tests instead of reusing his PR. |
No description provided.